Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contrib/opensergo): incorrect conversion between integer types #3309

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

demoManito
Copy link
Member

Description (what this PR does / why we need it):

https://github.com/go-kratos/kratos/security/code-scanning/2

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (a803e9d) to head (854d5c7).

❗ Current head 854d5c7 differs from pull request most recent head c39b305. Consider uploading reports for the commit c39b305 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3309      +/-   ##
==========================================
- Coverage   81.92%   81.78%   -0.15%     
==========================================
  Files          92       92              
  Lines        4205     4205              
==========================================
- Hits         3445     3439       -6     
- Misses        580      584       +4     
- Partials      180      182       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@ magical buns

@dosubot dosubot bot added the LGTM label Apr 30, 2024
@shenqidebaozi shenqidebaozi merged commit be624d0 into go-kratos:main Apr 30, 2024
33 checks passed
@demoManito demoManito deleted the fix/strconv branch April 30, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants