-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding stream interceptor for logging middleware #3359
adding stream interceptor for logging middleware #3359
Conversation
似乎可以直接用
或者复用 interceptors.StreamServerInterceptor() |
Using the above can cause conflict between using kratos middleware for unary and using grpc-middleware for stream server Does the above apply to all the middlewares: auth, circuit breaker, metadata, metrics, rate limit, recovery, selector, tracing, validate etc? |
70b6a92
to
576691b
Compare
@shenqidebaozi I updated the PR to have a middleware abstraction for the streaming middleware. grpc-gateway middleware also configure the unary and stream as separate interceptors configs |
@go-kratos/contributor please take a look and provide feedback. Another proposal to unify the unary and stream interface: akoserwal#1 |
ok, Let's discuss this design |
@shenqidebaozi updated the interceptor based on your suggestions |
d70260b
to
ac1b5c5
Compare
932ed31
to
c182e94
Compare
…unary middlewares
dd8ee27
to
b65b7e2
Compare
…t stream interface with streamMiddleware
@shenqidebaozi Is there anything remaining? please take a look |
@akoserwal I think it's ready now, but I need to test it again |
Description (what this PR does / why we need it):
Update the stream interceptor to handle stream use-case
Which issue(s) this PR fixes (resolves / be part of):
fixes #3351
Other special notes for the reviewers: