[fix] 解决json配置文件在热更新时，因系统触发两次文件写入事件，第一次读取到的配置内容为空，导致json解析失败报错的问题 #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
| @@ -52,6 +53,7 @@ func (w *watcher) Next() ([]*config.KeyValue, error) { | |||
| if fi.IsDir() { | |||
| path = filepath.Join(w.f.path, filepath.Base(event.Name)) | |||
| } | |||
| time.Sleep(time.Millisecond) | |||
There was a problem hiding this comment.
Can sleep here solve the problem?
There was a problem hiding this comment.
未添加Sleep前，每次保存配置触发的两次写事件时，第一次读取到的内容均为空。添加Sleep后，进行100次连续保存操作，每次触发的两次写事件，均能读取到文件内容。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
此为对空[]byte进行json.Unmarshal时的错误。
触发Write时，可能导致读取的内容为空
通过添加延时一毫秒去抖，能每次都读取到文件内容
2024/09/29 10:27:42 event: WRITE 2024/09/29 10:27:42 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:42 event: WRITE 2024/09/29 10:27:42 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:42 event: WRITE 2024/09/29 10:27:42 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:42 event: WRITE 2024/09/29 10:27:42 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:42 event: WRITE 2024/09/29 10:27:42 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:42 event: WRITE 2024/09/29 10:27:42 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:43 event: WRITE 2024/09/29 10:27:43 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:43 event: WRITE 2024/09/29 10:27:43 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:43 event: WRITE 2024/09/29 10:27:43 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:43 event: WRITE 2024/09/29 10:27:43 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:43 event: WRITE 2024/09/29 10:27:43 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:43 event: WRITE 2024/09/29 10:27:43 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:43 event: WRITE 2024/09/29 10:27:43 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:43 event: WRITE 2024/09/29 10:27:43 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:43 event: WRITE 2024/09/29 10:27:43 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:44 event: WRITE 2024/09/29 10:27:44 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:44 event: WRITE 2024/09/29 10:27:44 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:44 event: WRITE 2024/09/29 10:27:44 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:44 event: WRITE 2024/09/29 10:27:44 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:44 event: WRITE 2024/09/29 10:27:44 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:44 event: WRITE 2024/09/29 10:27:44 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:45 event: WRITE 2024/09/29 10:27:45 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:45 event: WRITE 2024/09/29 10:27:45 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:45 event: WRITE 2024/09/29 10:27:45 modified file: tmp/a.txt [49 50 51] 2024/09/29 10:27:45 event: WRITE 2024/09/29 10:27:45 modified file: tmp/a.txt [49 50 51]每次触发事件均能读取成功
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: