Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent negative waitgroup panic by Adding first. #237

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

ncabatoff
Copy link
Contributor

@ncabatoff ncabatoff commented Oct 29, 2019

Fixes #236.

Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for this PR and for reporting the issue.

@johnweldon johnweldon merged commit e69ea10 into go-ldap:master Oct 29, 2019
hahmadia added a commit to mattermost/ldap that referenced this pull request Nov 25, 2019
* unified request flow && external binding to LDAP (go-ldap#232)

* unified request flow && external binding to LDAP

* fix debug mode

* go.mod was added

* Prevent negative waitgroup panic by `Add`ing first. (go-ldap#237)

* Use github for module name. (go-ldap#239)

* Rename asn1 ber dependency. (go-ldap#243)

* Rename asn1.ber dependency.

* go mod tidy

* Update travic CI to new asn1 ber

* Update travis go_import_path

* Update README (go-ldap#245)

* Update go.mod (go-ldap#241)

I believe that this (plus a new tag) is what is necessary for native go modules support -- right now go modules complains that the version tag is >= v2 but the module doesn't claim to be a version >= v2.

* Versioned v3 according to Go wiki, maintaining backward compatibility (go-ldap#247)

* Moved v3 to subfolder to allow for versioning >2 with go modules. Reverted top level go.mod to fix backward compatibility

* Updated readme to include directions on Go Modules, including the rationale
@ncabatoff ncabatoff deleted the fix-conn-close-race branch January 14, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close can panic
2 participants