-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clean up sloghandler testing and restore coverage
This commit retools the way we do testing of sloghandler. It moves the test implementations of LogSink and SlogSink into new files and then runs the standard slog tests against them, which excercises both the SlogSlink and plain LogSink paths. It also retools sloghandler to handle slog Attrs a bit better and fixes some of the previous exceptions to slog's standard test. It still doesn't hande groups "properly", but this is simpler and users who really need slog support should use an impl that supports SlogSink (e.g. funcr).
- Loading branch information
Showing
7 changed files
with
356 additions
and
334 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.