testr: remove Logf from TestingT since it's not strictly required

go-logr · Jun 2, 2022 · 5ab368c · 5ab368c
1 parent 4683f8b
commit 5ab368c
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/testr/testr.go b/testr/testr.go
@@ -28,7 +28,6 @@ import (
 type TestingT interface {
 	Helper()
 	Log(args ...interface{})
-	Logf(format string, args ...interface{})
 }
 
 // New returns a logr.Logger that prints through a testing.T object.
@@ -116,10 +115,9 @@ func logInfo(
 	prefix, args := formatInfo(level, msg, kvList)
 	t.Helper()
 	if prefix != "" {
-		t.Logf("%s: %s", prefix, args)
-	} else {
-		t.Log(args)
+		args = prefix + ": " + args
 	}
+	t.Log(args)
 }
 
 func logError(
@@ -132,10 +130,9 @@ func logError(
 	prefix, args := formatError(err, msg, kvList)
 	t.Helper()
 	if prefix != "" {
-		t.Logf("%s: %s", prefix, args)
-	} else {
-		t.Log(args)
+		args = prefix + ": " + args
 	}
+	t.Log(args)
 }
 
 type testlogger struct {