Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funcr: Allow customization of the timestamp format #114

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

thockin
Copy link
Contributor

@thockin thockin commented Oct 19, 2021

I had forgotten this commit in a stash.

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but perhaps add some tests to avoid future regressions?

@thockin
Copy link
Contributor Author

thockin commented Oct 20, 2021

Yep! Done.

@pohly pohly merged commit 62568d8 into go-logr:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants