Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funcr: fix example verbosity #122

Merged
merged 1 commit into from
Nov 30, 2021
Merged

funcr: fix example verbosity #122

merged 1 commit into from
Nov 30, 2021

Conversation

thockin
Copy link
Contributor

@thockin thockin commented Nov 30, 2021

No description provided.

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slightly more verbose commit message would have been nice 😅

As it stands, I had to guess and check the full file to find out that "you should see this" gets logged at V(1) was meant to be printed.

@pohly pohly merged commit dd8f76f into go-logr:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants