Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If logging as JSON and the type is json.RawMessage log it "as-is" #147

Merged
merged 7 commits into from
Nov 10, 2022
Merged

If logging as JSON and the type is json.RawMessage log it "as-is" #147

merged 7 commits into from
Nov 10, 2022

Commits on Aug 2, 2022

  1. If logging as JSON and the type is json.RawMessage log it "as-is". 

    If we're already producing JSON and a sub message field is json.RawMessage (i.e. []byte) then emit it as-is.

Otherwise you get [X,Y,Z,..] style which is pretty useless in log in that form.
    @sfc-gh-jchacon
    sfc-gh-jchacon committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    de56336 View commit details
    Browse the repository at this point in the history

  2. Update comment

    @sfc-gh-jchacon
    sfc-gh-jchacon committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    2284408 View commit details
    Browse the repository at this point in the history

  3. Change path so we can use this as a fork as needed

    @sfc-gh-jchacon
    sfc-gh-jchacon committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    aabcc82 View commit details
    Browse the repository at this point in the history

  4. Add test for empty array so in JSON mode emit {} instead of []

    @sfc-gh-jchacon
    sfc-gh-jchacon committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    01ef30d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Change empty JSON response that is a json.RawMessage to null instead … 

    …of {} to handle

corner cases that might be expecting a different type there
    @sfc-gh-jchacon
    sfc-gh-jchacon committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    d51c6b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Fix unit test after recent {}->null change

    @sfc-gh-jchacon
    sfc-gh-jchacon committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    30bd08f View commit details
    Browse the repository at this point in the history

  2. Remove dup test

    @sfc-gh-jchacon
    sfc-gh-jchacon committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    a8d7af6 View commit details
    Browse the repository at this point in the history