Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SlogSink support to funcr #241

Merged
merged 11 commits into from
Dec 8, 2023
Merged

Add SlogSink support to funcr #241

merged 11 commits into from
Dec 8, 2023

Commits on Dec 8, 2023

  1. Minor cleanups in slogr_test (readability)

    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    cdb930d View commit details
    Browse the repository at this point in the history

  2. Get rid of testSlogSink

    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    d95f9b6 View commit details
    Browse the repository at this point in the history

  3. Add SlogSink support to funcr 

    Some of the testing done in slogr_test.go should probably be in funcr,
but the test jig is just complex enough that I don't want to duplicate
it in this commit.  Later.
    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    8221825 View commit details
    Browse the repository at this point in the history

  4. funcr: Be consistent about commas 

    This uncovered a bug where it would sometimes write to the input list,
corrupting tests.
    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    955d2aa View commit details
    Browse the repository at this point in the history

  5. funcr: Be consistent about colons

    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    44c6ac8 View commit details
    Browse the repository at this point in the history

  6. funcr: Be consistent about quoted

    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b5e7d9f View commit details
    Browse the repository at this point in the history

  7. Fix some lint

    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    83dbe72 View commit details
    Browse the repository at this point in the history

  8. Put slog tests in a helper, move funcr test

    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f558531 View commit details
    Browse the repository at this point in the history

  9. Add benchmarks for slogSink

    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    6432877 View commit details
    Browse the repository at this point in the history

  10. Break examples to new file

    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b228ba8 View commit details
    Browse the repository at this point in the history

  11. Clean up slog testing and restore coverage

    @thockin
    thockin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    98ee9d9 View commit details
    Browse the repository at this point in the history