Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slog support: fix WithGroup + WithValues combination #243

Merged
merged 2 commits into from
Dec 4, 2023

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    c7d1b58 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. unit tests with full SlogSink mock implementation

    This turns testLogSink into an implementation of SlogSink if slog is supported,
    then runs through some scenarios where values get added using different APIs.
    The end result gets compared by formatting with the slog JSON handler because
    that is easier than writing custom code for a deep-equal comparison of slog
    attributes.
    
    The "with-group-and-logr-values" is the case which was broken.
    pohly committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    ffd51a4 View commit details
    Browse the repository at this point in the history