Skip to content

Commit

Permalink
replication: Fix replica UUID registration
Browse files Browse the repository at this point in the history
If we send `SET @replica_uuid=` after `COM_REGISTER_SLAVE` it won't be
picked up in `SHOW REPLICAS`.
  • Loading branch information
dveeden committed Jan 10, 2025
1 parent dd23731 commit 6cbab12
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions replication/binlogsyncer.go
Original file line number Diff line number Diff line change
Expand Up @@ -348,14 +348,6 @@ func (b *BinlogSyncer) registerSlave() error {
}
}

if err = b.writeRegisterSlaveCommand(); err != nil {
return errors.Trace(err)
}

if _, err = b.c.ReadOKPacket(); err != nil {
return errors.Trace(err)
}

serverUUID, err := uuid.NewUUID()
if err != nil {
b.cfg.Logger.Errorf("failed to get new uuid %v", err)
Expand All @@ -366,6 +358,14 @@ func (b *BinlogSyncer) registerSlave() error {
return errors.Trace(err)
}

if err = b.writeRegisterSlaveCommand(); err != nil {
return errors.Trace(err)
}

if _, err = b.c.ReadOKPacket(); err != nil {
return errors.Trace(err)
}

return nil
}

Expand Down

0 comments on commit 6cbab12

Please sign in to comment.