ISSUE-169: GOENV_GOPATH_PREFIX does not work as expected #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rehash is executed and GOENV_DISABLE_GOPATH is 0 (default) the code should use currentVersionName instead becasue GOENV_VERSION is not set.
|
Ok, the latest commit eventually fixed the OSX build too, so this should be good to go in. |
syndbg
approved these changes
Mar 31, 2021
syndbg
added a commit
that referenced
this pull request
Oct 16, 2022
* add 1.14.1 and 1.13.9 (#116) * 🎉 add 1.14.1 * 🎉 add 1.13.9 * 💚 Fix order * add 1.14.2 and 1.13.10 (#120) * Add ZPlug installation instructions (#122) * add 1.14.3 and 1.13.11 (#124) * 🎉 add 1.14.3 * 🎉 add 1.13.10 * automatic shims (#119) #30 Thanks for https://github.com/kadaan #30 (comment) https://github.com/kadaan/goenv-goget-rehash * add 1.14.4 and 1.13.12 (#125) * 🎉 add 1.14.4 * 🎉 add 1.13.12 * 🎉 add 1.15beta1 (#126) * Remove duplicate test (#128) * Remove duplicate test * Set specific bats version * add 1.14.5 and 1.13.13 (#127) * 🎉 add 1.14.5 * 🎉 add 1.13.13 * 👍 Update hash for go1.14.5.darwin-amd64.tar.gz * add 1.14.6 and 1.13.14 (#129) * 🎉 add 1.14.6 * 🎉 add 1.13.14 * 🐛 Change link from Installer to Archive for Go Darwin 64bit 1.13.13 * add 1.15rc2 (#134) * 🎉 add 1.15rc2 * Add test * add 1.13.15 (#137) * add 1.13.15 * add 1.13.15 * 🎉 add 1.15.0 (#138) * add 1.14.7 (#135) * Add 1.15.1 and 1.14.8 (#139) * 🎉 add 1.15.1 * 🎉 add 1.14.8 * 🐛 Change tab to white space * 🐛 Change tab to white space * supper go1.15.2 (#142) Co-authored-by: yunling.zhang <yunling.zhang@rakuten.com> Co-authored-by: Anton Antonov <anton.synd.antonov@gmail.com> * add 1.14.9 (#141) Co-authored-by: Anton Antonov <anton.synd.antonov@gmail.com> * Add 1.15.3 and 1.14.10 (#149) * 🎉 add 1.15.3 * 🎉 add 1.15.3 * 🎉 add 1.14.10 * search relative to bin_path for plugins (#146) * search relative to bin_path for plugins * search relative to bin_path for plugins * Add 1.15.4 and 1.14.11 (#152) * 🎉 add 1.15.4 * 🎉 add 1.14.11 * Add 1.15.5 and 1.14.12 (#153) * 🎉 add 1.15.5 * 🎉 add 1.14.12 * Add 1.15.6 and 1.14.13 (#154) * 🎉 Add 1.15.6 * 🎉 add 1.14.13 * 🎉 add 1.16beta1 (#155) * Support darwin-arm64 arch in 1.16beta1 (#158) * Add Linux arm 64bit (#159) * Add 1.15.7 and 1.14.14 (#160) * 🎉 add 1.15.7 * 🎉 add 1.14.14 * Add GOENV_APPEND_GOPATH and GOENV_PREPEND_GOPATH (#148) This adds two new environment variable options to optionally persist user-configured GOPATH when enabled. * clean up init function (#161) - always export GOENV_ROOT - do not append to PATH if entry already exists * Add 1.15.8 and 1.14.15 (#162) * add 1.15.8 * Add 1.14.15 * Add Go 1.16 (#164) * Fix linux arm 64bit version in link (#166) * Add 1.15.9 and 1.16.1 (#165) * Add 1.15.9 * Add 1.16.1 * Add go 1.15.10 and 1.16.2 (#167) * add 1.15.10 * add 1.16.2 * ISSUE-169: GOENV_GOPATH_PREFIX does not work as expected (#170) * ISSUE-169: GOENV_GOPATH_PREFIX does not work as expected When rehash is executed and GOENV_DISABLE_GOPATH is 0 (default) the code should use currentVersionName instead becasue GOENV_VERSION is not set. * Fix OSX builds * Update osx_image to latest Xcode * Add go1.16.3 (#174) Co-authored-by: Henry Nguyễn <hunnguye@amazon.com> * 🎉 add 1.15.11 (#175) * Use a POSIX-compatible regex in goenv-version-file-read (#176) * Add 1.16.4 and 1.15.12 (#178) * Add 1.16.5 and 1.15.13 (#181) * Add 1.16.6, 1.15.14 and 1.17beta1 (#183) * Add 1.16.6 and 1.15.14 * Add 1.17beta1 * Add 1.17rc1 (#185) * Show progress bar during download tarball (#187) * Add 1.15.15, 1.16.7 and 1.17rc2 (#189) * Add 1.17rc2 * Add 1.16.7 and 1.15.15 * Add 1.17 (#193) * Add 1.17.1 and 1.16.8 (#195) * Add 1.17.2 and 1.16.9 (#196) * Use correct checksum for Go Darwin arm 1.17.2 (#197) * Add 1.17.3 and 1.16.10 (#199) * test_assert_helper: use type -aP instead of which -a (#201) which might not be installed, but type is a bash builtin. * Add 1.17.4, 1.17.5, 1.16.11 and 1.16.12 (#204) * Add 1.17.4 and 1.16.11 * Add 1.17.5 and 1.16.12 * Add 1.18beta1 (#208) * Add 1.17.6 and 1.16.13 (#211) Co-authored-by: Anton Antonov <anton.synd.antonov@gmail.com> * Update realpath extension source with upstream changes (#206) This fixes building the extension on macOS 12. * Add 1.18beta2 (#212) * Add 1.16.14 & 1.17.7 (#213) * Adds support for 1.18rc1 release (#214) * add 1.17.8 and 1.16.15 (#216) * Support go 1.18.0 (#217) Signed-off-by: moznion <moznion@mail.moznion.net> * support 1.18.1 (#219) * Support go 1.17.9 (#221) * feat: suport force darwin arch (#220) * Go 1.18.2 (#224) * Support Go 1.18.2 * fix tests * Add Go 1.17.10 (#225) * Support Go 1.18.3 (#228) Co-authored-by: Henry <henry@nguyen.gg> * fix tar.gz MacOS checksum (#229) * Support go 1.17.11 (#231) * Add go1.19beta1 support (#232) * Support Go 1.18.4 and 1.17.12 (#236) * Support Go 1.18.4 * Support Go 1.17.12 * Remove redundant command prompts (#235) * Support Go 1.18.5 and 1.17.13 (#239) * Support Go 1.18.5 * Support Go 1.17.3 * Add go1.19.0 support (#240) * Doc: simplify git cmd for upgrade & checkout version (#242) * Support Go 1.19.1 and 1.18.6 (#245) * Support Go 1.19.1 * Support Go 1.18.6 * If `.go-version` is missing, fallback on `go.mod` (#227) * First step: attempting to make `goenv-version-file` and `goenv-version-file-read` to fallback on `go.mod` * simplify go mod parsing * fix existing unit tests * add unit tests for go mod * add feat flag constraint * add negative test case for feature flag as well Co-authored-by: ChronosMasterOfAllTime <efstathiosc@gmail.com> * Support 1.19.2 and 1.18.7 (#250) * support 1.19.2 and 1.18.7 * add new versions to bats * Add github action * Test * keep contexts of shell in makefile per step * update runner file * rename blank.yml -> pr_checks.yml * try default shell of bash in makefile * print bash version * force bash * try only awk? * Try gawk * is go installed * try to remove golang * root * remove golang * back to awk * check macos version print out * try the read method for populating the array * try thetrim method * use zero index macOS * fix runner and add status badge Signed-off-by: moznion <moznion@mail.moznion.net> Co-authored-by: Toshinori Sugita <s.toshi0607@gmail.com> Co-authored-by: takisawa <takisawa@hit-start.jp> Co-authored-by: Andy Palmer <andy@andypalmer.com> Co-authored-by: ฐฏ <jimmy.m.gong@gmail.com> Co-authored-by: Anton Antonov <anton.synd.antonov@gmail.com> Co-authored-by: Willy Li <23062765+xgnl@users.noreply.github.com> Co-authored-by: Thibault NORMAND <Zenithar@users.noreply.github.com> Co-authored-by: Joy_Zhang <yun313350095@gmail.com> Co-authored-by: yunling.zhang <yunling.zhang@rakuten.com> Co-authored-by: David Tapiador <nogates@users.noreply.github.com> Co-authored-by: cornfeedhobo <cornfeedhobo@users.noreply.github.com> Co-authored-by: ITO Nobuaki <daydream.trippers@gmail.com> Co-authored-by: Shingo Kawamura <blp1526@gmail.com> Co-authored-by: kangaechu <kangae2@gmail.com> Co-authored-by: Radek Simko <radek.simko@gmail.com> Co-authored-by: Ville Skyttä <ville.skytta@iki.fi> Co-authored-by: Aaron Russo <aaron.n.russo@gmail.com> Co-authored-by: Mark "debo" De Bortoli <debo@users.noreply.github.com> Co-authored-by: Henry <5065089+nguyengg@users.noreply.github.com> Co-authored-by: Henry Nguyễn <hunnguye@amazon.com> Co-authored-by: oshiro <ariteku@gmail.com> Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com> Co-authored-by: umatare5 <72645163+umatare5@users.noreply.github.com> Co-authored-by: Gareth Jones <Jones258@Gmail.com> Co-authored-by: Ville Skyttä <ville.skytta@upcloud.com> Co-authored-by: Martin Holman <me@martinholman.co.nz> Co-authored-by: Colin Goodheart-Smithe <colings86@users.noreply.github.com> Co-authored-by: Masa <Lim79Plus@users.noreply.github.com> Co-authored-by: moznion <moznion@mail.moznion.net> Co-authored-by: Wenchao Hu <me@huwenchao.com> Co-authored-by: Charlie Voiselle <464492+angrycub@users.noreply.github.com> Co-authored-by: Luke Van Oort <johnvanoort@gmail.com> Co-authored-by: Pavlo Romanenko <mail@pvlrmnnk.com> Co-authored-by: Henry <henry@nguyen.gg> Co-authored-by: Shuhei Kitagawa <shuheiktgw@users.noreply.github.com> Co-authored-by: Filip Sergot <filip.sergot@gmail.com> Co-authored-by: Kohji Nakahata <1259591+nakakoh@users.noreply.github.com> Co-authored-by: Chen Ni <nichen301@sina.com> Co-authored-by: uedaeita <eitaro.ueda@gmail.com> Co-authored-by: LittleKey <LittleKeyRain@gmail.com> Co-authored-by: Alpha <AlphaWong@users.noreply.github.com> Co-authored-by: Ivan De Marino <ivan.de.marino@gmail.com> Co-authored-by: Koya IWAMURA <kiwamura0314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rehash is executed and GOENV_DISABLE_GOPATH is 0 (default)
the code should use currentVersionName instead becasue GOENV_VERSION is
not set.