Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled Checks for new Go Definitions via GitHub Actions #261

Conversation

ChronosMasterOfAllTime
Copy link
Contributor

@ChronosMasterOfAllTime ChronosMasterOfAllTime commented Oct 31, 2022

The goal of this PR is to address the idea referenced in #253. Theere will be an automatic PR that gets opened if the following conditions are satisfied:

  • the latest go version doesn't already have a definition file
  • another PR doesn't already exist

The Action will run once a day.

Script has been tested for the above scenarios.

The downside is it will require we create an access token and add it to the secrets for this repo.

@detro @syndbg any thoughts as well? This will keep any sub dependencies out of goenv and isolated to this action

@ChronosMasterOfAllTime ChronosMasterOfAllTime changed the title WIP: Auto go download Bot WIP: Scheduled Checks for new Go Definitions Oct 31, 2022
@ChronosMasterOfAllTime ChronosMasterOfAllTime changed the title WIP: Scheduled Checks for new Go Definitions WIP: Scheduled Checks for new Go Definitions via GitHub Actions Oct 31, 2022
@ChronosMasterOfAllTime ChronosMasterOfAllTime changed the title WIP: Scheduled Checks for new Go Definitions via GitHub Actions Scheduled Checks for new Go Definitions via GitHub Actions Oct 31, 2022
@ChronosMasterOfAllTime ChronosMasterOfAllTime marked this pull request as ready for review October 31, 2022 05:27
@ChronosMasterOfAllTime
Copy link
Contributor Author

ChronosMasterOfAllTime commented Oct 31, 2022

See 4bbc31c for an example commit opened by the script. (PR #268)

@syndbg You will need to generate a classic PAT with full repo access as the GraphQL API doesn't support the new fine-grained PATs. Add it as a repo action secret GH_TOKEN

@syndbg
Copy link
Member

syndbg commented Nov 1, 2022

Failed to add secret. Secret names must not start with GITHUB_.  

😅

@ChronosMasterOfAllTime
Copy link
Contributor Author

@syndbg let me know what the secret name is and I will update the script 😂

@ChronosMasterOfAllTime
Copy link
Contributor Author

ChronosMasterOfAllTime commented Nov 4, 2022

@syndbg should we make a bot user with a PAT so it's tied to neither of our accounts? (Thinking of security here). (e.g. goenv-bot)

@goenv-bot
Copy link
Contributor

@syndbg I am your new bot account, created by @ChronosMasterOfAllTime

@ChronosMasterOfAllTime
Copy link
Contributor Author

I have the PAT for the Bot to be able to do its job

@ChronosMasterOfAllTime
Copy link
Contributor Author

@syndbg when do you have time to help work on this? Or temporarily give me access to set up the repo secrets?

@ChronosMasterOfAllTime ChronosMasterOfAllTime force-pushed the auto_go_download branch 2 times, most recently from b1a8d93 to b233961 Compare February 19, 2023 05:40
@syndbg
Copy link
Member

syndbg commented Feb 21, 2023

Hey, a bit of a busy week but I'll try to see it in more details during the weekend.

@davidlanouette
Copy link

This PR looks like it's been forgotten about. Will someone have time in the near future to merge it?

@ChronosMasterOfAllTime
Copy link
Contributor Author

ChronosMasterOfAllTime commented Jul 13, 2023

This PR looks like it's been forgotten about. Will someone have time in the near future to merge it?

I need temporary admin access to create secrets. Waiting on @syndbg .

Another idea was for me to fork this repo and have the action run there. I also want to add release drafter so it can auto release versions as needed. Once a release is published I will create an action to auto PR into homebrew. It will save me a ton of time!

@ChronosMasterOfAllTime
Copy link
Contributor Author

closing this PR in favor of #3

@ChronosMasterOfAllTime ChronosMasterOfAllTime deleted the auto_go_download branch July 25, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants