Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's not possible to differentiate between confidential and public oauth2 clients? #232

Closed
jarlandre opened this issue Jan 20, 2023 · 1 comment

Comments

@jarlandre
Copy link

jarlandre commented Jan 20, 2023

ref https://oauth.net/2/client-types/

This oauth2 server implementation is not allowing to store nor treats confidential clients differently from public.

This is a problem, and is also the reason why its not possible to make public only clients that only can use auth flow code grant with PKCE, without fixing it like i did in #230. Which basically circumvents this by allowing to set a secret on a client, and at the same time allowing secret-less auth code flow. Without my suggested fix, if you set secret to blank or nil value, you will be able to request a token from the token endpoint with client_credentials grant, without even passing in the secret, which is horrendous

EDIT: remade the #230 PR into a new PR #234

@jarlandre
Copy link
Author

fixed by #234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant