fix server_test.go so it works + make code flow test pass with no secret

[jarlandre]

1. Remove query encoding of urls for redirect uri in server_test.go to make tests successfully hit the /oauth2 callback endpoint
2. Then fix the token requests in the auth code flow tests
3. Then fix the manager to allow for no client_secret for auth code flow with pkce where code verifier is at least 43 chars. EDIT: i see there might not be need to check its length and only its existence. Its already validated properly. Merely checking that that code verifier is not empty string will be enough to ensure that the request will fail without the proper code verifier.

• Remove length check on code verifier and only check if its a non-empty string
• actually we need to differentiate between confidential and public clients, which this server library cannot, afaik. EDIT: new draft PR here Introducing public field to client models #233

the pkce spec states that code verifier should be minimum 43 chars (#230 (comment)), should this be verified earlier in the process?

[jarlandre]

☝️ @LyricTian

[jarlandre]

quote:

code_verifier — The code verifier should be a high-entropy cryptographic random string with a minimum of 43 characters and a maximum of 128 characters.

[jarlandre]

./go.test.sh
ok  	github.com/go-oauth2/oauth2/v4	0.203s	coverage: 42.9% of statements
?   	github.com/go-oauth2/oauth2/v4/errors	[no test files]
?   	github.com/go-oauth2/oauth2/v4/example/client	[no test files]
?   	github.com/go-oauth2/oauth2/v4/example/server	[no test files]
ok  	github.com/go-oauth2/oauth2/v4/generates	0.219s	coverage: 77.8% of statements
ok  	github.com/go-oauth2/oauth2/v4/manage	0.211s	coverage: 61.8% of statements
?   	github.com/go-oauth2/oauth2/v4/models	[no test files]
ok  	github.com/go-oauth2/oauth2/v4/server	0.237s	coverage: 53.6% of statements
ok  	github.com/go-oauth2/oauth2/v4/store	2.314s	coverage: 87.2% of statements

[DennisMuchiri]

@jarlandre why was this not merged?

[jarlandre]

because it war replaced by another PR .. see mentions

[jarlandre]

should have rebased and kept it in this PR i guess .. live and learn

[shynome]

here is a tip: how to work with pcke , you need change the ClientInfoHandler to resolve invalid_client error

srv.SetClientInfoHandler(server.ClientFormHandler)