Introduce environment variables to customize running tests #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
reviewed
Oct 21, 2019
db_test.go
Outdated
| User: "postgres", | ||
| Database: "postgres", | ||
| User: pg.GetPGUser(), | ||
| Database: pg.GetPGDatabase(), |
There was a problem hiding this comment.
I think you can leave these empty so they are auto-populated later in options.go
vmihailenco
reviewed
Oct 21, 2019
| } | ||
| return pgDatabase | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you please unexport all these functions? I don't think they should be part of the public API.
I think we don't need these functions at all - just inline the code in options init, e.g.
if opt.Database == "" {
opt.Database = env("PGDATABASE", "postgres")
}
func env(key, defValue string) string {
}
elliotcourant
requested changes
Oct 24, 2019
options_test.go
Outdated
| @@ -132,7 +132,7 @@ func TestParseURL(t *testing.T) { | |||
| }, | |||
| { | |||
| "postgres://vasya:pupkin@somewhere.at.amazonaws.com/postgres", | |||
| "somewhere.at.amazonaws.com:5432", | |||
| "somewhere.at.amazonaws.com:" + GetPGPort(), | |||
There was a problem hiding this comment.
Given that these are not actually used for connections, and are purely for testing the parsing capability, i would not change any of these.
There was a problem hiding this comment.
Thanks. I think I went overboard with the changes, reverted.
This commit adds the support of some environment variables (namely, PGHOST, PGPORT, PGUSER, PGDATABASE, and PGSSLMODE) that override certain options when running tests. The inspiration is taken from lib/pq tests (https://www.postgresql.org/docs/9.3/libpq-envars.html). For every option, the corresponding environment variable is first checked. If it is present, then the value is used; if it is not present or empty, then we fall back to using the default values.
yuzefovich
force-pushed
the
add-test-env-vars
branch
from
aec3039
to
f0bf4ea
Compare
|
Thank you! |
DarrylWong
added a commit
to DarrylWong/pg
that referenced
this pull request
Jan 23, 2024
In go-pg#1429, environment variable were added to read in postgres connection details for customizing tests. This change does the same but with a password variable.
DarrylWong
added a commit
to DarrylWong/pg
that referenced
this pull request
Jan 23, 2024
In go-pg#1429, environment variable were added to read in postgres connection details for customizing tests. This change does the same but with a password variable.
DarrylWong
added a commit
to DarrylWong/pg
that referenced
this pull request
Jan 23, 2024
In go-pg#1429, environment variable were added to read in postgres connection details for customizing tests. This change does the same but with a password variable.
DarrylWong
added a commit
to DarrylWong/pg
that referenced
this pull request
Jan 23, 2024
In go-pg#1429, environment variables were added to read in postgres connection details for customizing tests. This change does the same but with a password variable.
DarrylWong
added a commit
to DarrylWong/pg
that referenced
this pull request
Jan 23, 2024
In go-pg#1429, environment variables were added to read in postgres connection details for customizing tests. This change does the same but with a password variable. It also removes the hardcoded user and password values from pgOptions, as Options init() will set the default if one is not specified.
DarrylWong
added a commit
to DarrylWong/pg
that referenced
this pull request
Jan 23, 2024
In go-pg#1429, environment variables were added to read in postgres connection details for customizing tests. This change does the same but with a password variable. It also removes the explicit user and password values from pgOptions, as Options init() will set it as postgres anyway if not specified, and enabling env variables to be used instead.
DarrylWong
added a commit
to DarrylWong/pg
that referenced
this pull request
Jan 23, 2024
In go-pg#1429, environment variables were added to read in postgres connection details for customizing tests. This change does the same but with a password variable. It also removes the explicit user and password values from pgOptions, as Options init() will set it as postgres anyway if not specified. This also enables env variables to be used instead for those values.
elliotcourant
pushed a commit
that referenced
this pull request
Jan 23, 2024
In #1429, environment variables were added to read in postgres connection details for customizing tests. This change does the same but with a password variable. It also removes the explicit user and password values from pgOptions, as Options init() will set it as postgres anyway if not specified. This also enables env variables to be used instead for those values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the support of some environment variables (namely,
PGHOST, PGPORT, PGUSER, PGDATABASE, and PGSSLMODE) that override
certain options when running tests. The inspiration is taken from
lib/pq tests (https://www.postgresql.org/docs/9.3/libpq-envars.html).
For every option, the corresponding environment variable is first
checked. If it is present, then the value is used; if it is not present
or empty, then we fall back to using the default values.