[Draft] Add support for setting PIN/PUK retries #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quantu
force-pushed
the
add_setting_pin_puk_retries
branch
2 times, most recently
from
5316808
to
5c0b94f
Compare
…ting them. Prefer AES192 over 3DES when possible.
…e error messages to indicate key type and allowed key lengths
…ort firmware version
…anagement key type, relocate version/keytype code from SetManagementKey to ykSetManagementKey, move ykAuthenticate call from ykSetMetadata to SetMetadata for consistency
…nd ints to eliminate a lot of unnecessary calls to .Version()
Quantu
force-pushed
the
add_setting_pin_puk_retries
branch
from
7caf382
to
a2629a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the changes already made for adding AES management key support - I'll make a proper rebased non-draft PR once #149 is resolved one way or another.