Add v2 with generics #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
force-pushed
the
paskal/generics
branch
2 times, most recently
from
a12379d to
0da3b2b
Compare
paskal
force-pushed
the
paskal/generics
branch
2 times, most recently
from
0b1bf28 to
b74880a
Compare
umputun
reviewed
Feb 18, 2024
paskal
force-pushed
the
paskal/generics
branch
from
b74880a to
4375d49
Compare
|
Looking good. I'm not a big fan of using reflection for Redis, but it's likely the right approach in this situation. Please ping me once you're done with everything, and I'll take a closer look. |
paskal
force-pushed
the
paskal/generics
branch
from
4375d49 to
6d33e2b
Compare
|
@umputun, everything is ready for review. It took some time for me to figure out how to combine two coverage profiles into one for a proper coverage report. |
paskal
force-pushed
the
paskal/generics
branch
from
ad654ac to
59ee585
Compare
The code in github.com/hashicorp/golang-lru/v2/expirable was provided by me and was inspired by the code here.
paskal
force-pushed
the
paskal/generics
branch
from
59ee585 to
4847b39
Compare
umputun
requested changes
Feb 19, 2024
|
The Redis problem seems to be redis/go-redis#2914. It should be fixed upstream, as it affects a lot of cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis cache creation will return an error if used with a type which is not a string or not based on a string.
Resolves #31 and #39.