Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify tests confusions with mux usage, remove Mux accessor #6

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

umputun
Copy link
Member

@umputun umputun commented Mar 12, 2024

The presence of the Bundle.Mux accessor seems largely superfluous and potentially confusing. Moreover, it reveals excessive internal details, thereby hindering modifications. For instance, it obstructs shifts in the core strategy, such as applying middleware not to each registered route individually, but to groups or subgroups of routes.

Also adjusted tests to use the group as a handler, not the underlying mux

@umputun umputun merged commit af8e4d4 into master Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant