Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filepath validator panic if the value is an existing dir #1133

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Fix filepath validator panic if the value is an existing dir #1133

merged 1 commit into from
Aug 6, 2023

Conversation

nodivbyzero
Copy link
Contributor

@nodivbyzero nodivbyzero commented Jul 28, 2023 •
edited
Loading

Fixes Or Enhances

This PR adds an additional check for directories in the isFilePath() function.

Connected to #1102

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@nodivbyzero nodivbyzero requested a review from a team as a code owner July 28, 2023 00:57
@coveralls
Copy link

Coverage Status

coverage: 73.962% (-0.01%) from 73.972% when pulling dcd21e8 on nodivbyzero:validator-file-path-fix-is-dir into bd1113d on go-playground:master.

@deankarn deankarn merged commit 842a796 into go-playground:master Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nodivbyzero @coveralls @deankarn