Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cron validation support for star step value #1302

Conversation

cgetzen
Copy link
Contributor

@cgetzen cgetzen commented Aug 8, 2024

Fixes Or Enhances

Resolves #1259

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@cgetzen cgetzen requested a review from a team as a code owner August 8, 2024 16:36
@coveralls
Copy link

Coverage Status

coverage: 74.291%. remained the same
when pulling 046c53a on cgetzen-forks:cg/cron-validation-star-step-value
into a947377 on go-playground:master.

@ccoVeille
Copy link

ccoVeille commented Aug 8, 2024

Not related to your changes, but is format like 9-59/7 correctly supported?

@yazver
Copy link

yazver commented Nov 3, 2024

It's actual!

@geoff-rmtech
Copy link

Glad to see this PR - I've been unable to use a quarterly cron job "0 0 1 */3 *" - which this PR would fix.

@deankarn deankarn merged commit 51697fb into go-playground:master Nov 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron validator is not correct
6 participants