Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file path validation #375

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Add file path validation #375

merged 1 commit into from
Jun 28, 2018

Conversation

noibar
Copy link
Contributor

@noibar noibar commented Jun 27, 2018 •
edited
Loading

Fixes Or Enhances # .

Make sure that you've checked the boxes below before you submit PR:

  • [v] Tests exist or have been written that cover this particular change.

Change Details:

@go-playground/admins

@noibar noibar force-pushed the add_file_validation branch from 6cb5a10 to 6d27f82 Compare June 27, 2018 12:59
@noibar noibar force-pushed the add_file_validation branch from 6d27f82 to f2fdb60 Compare June 27, 2018 13:05
@deankarn
Copy link
Contributor

looks great @noibar!

@deankarn deankarn merged commit 7151074 into go-playground:v9 Jun 28, 2018
@deankarn
Copy link
Contributor

@noibar I know I've already merged, but would you be able to add documentation to doc.go for your validation?

I totally forgot to ask, will hold off on cutting the release until then :)

@noibar
Copy link
Contributor Author

noibar commented Jun 28, 2018

Done :)

fairyhunter13 added a commit to fairyhunter13/validator that referenced this pull request Jul 12, 2020
@fairyhunter13
Merge pull request go-playground#375 from noibar/add_file_validation
23c9137 
Add file path validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noibar @deankarn