Add hostname_port validator feature #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deankarn or anyone.. can you guys take a look? |
|
@deankarn Added the documentation. |
cchung100m
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Hi @terala
Thanks for correcting the regex of RFC-1123 and LGTM :)
fairyhunter13
added a commit
to fairyhunter13/validator
that referenced
this pull request
Jul 12, 2020
Add hostname_port validator feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances # 562
Change Details:
hostname_portvalidator. Tests added for this validator.hostnameRegexStringRFC1123so it will reject hostnames likeextra..com.@go-playground/admins