Add checksum validation for Ethereum address #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elias19r
commented
Jul 3, 2020
elias19r
commented
Jul 3, 2020
| h.Write([]byte(strings.ToLower(address))) | ||
| hash := hex.EncodeToString(h.Sum(nil)) | ||
|
|
||
| for i := 0; i < len(address); i++ { |
There was a problem hiding this comment.
Here len(address) definitely has value 40, but I preferred to write len(address) instead of 40. Thus we keep the information that "Ethereum addresses have 40 hex digits" declared only in one place, in the regexes.go (ethAddress{Upper,Lower,}RegexString).
Let me know if otherwise
JuarezLustosa
approved these changes
Jul 6, 2020
|
@elias19r made one suggested change, other than that looks great and can merge next time I merge a group of PR's |
Explicitly indicate we are ignoring errors from hash.Hash's io.Writer implementation Co-authored-by: Dean Karn <Dean.Karn@gmail.com>
|
@deankarn Thank you, let me know if you would like me to squash commits or you'll do it upon merging |
|
@elias19r I'll do it during the merge no worries |
This was referenced Jun 6, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances #631
Make sure that you've checked the boxes below before you submit PR:
Change Details:
@go-playground/admins