Update parseDuration, skip empty values

go-pogo · Jan 26, 2023 · 4040919 · 4040919
1 parent 6426d35
commit 4040919
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/parse.go b/parse.go
@@ -48,6 +48,10 @@ func unmarshalText(val Value, dest interface{}) error {
 }
 
 func parseDuration(val Value, dest interface{}) error {
+	if val.Empty() {
+		return nil
+	}
+
 	d, err := time.ParseDuration(val.String())
 	if err != nil {
 		return err

diff --git a/value.go b/value.go
@@ -14,8 +14,6 @@ const (
 	ValidationError errors.Kind = "validation error"
 )
 
-var Separator = ","
-
 func errKind(err error) errors.Kind {
 	if ne, ok := err.(*strconv.NumError); ok {
 		if ne.Err == strconv.ErrRange {
@@ -34,7 +32,7 @@ func errKind(err error) errors.Kind {
 type Value string
 
 // Empty indicates if Value is an empty string.
-func (v Value) Empty() bool { return v.String() == "" }
+func (v Value) Empty() bool { return string(v) == "" }
 
 func (v Value) GoString() string { return `parseval.Value("` + v.String() + `")` }