Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid User-Agent header value #175

Closed
korlowski opened this issue Aug 14, 2018 · 3 comments · Fixed by #176
Closed

Invalid User-Agent header value #175

korlowski opened this issue Aug 14, 2018 · 3 comments · Fixed by #176
Assignees
@jeevatkm
Labels
bug
Milestone
v1.9.0 Milestone

Comments

@korlowski
Copy link

The value of the User-Agent header go-resty v1.1 - https://github.com/go-resty/resty does not match the specification (see RFC 7231). A valid header should look something like go-resty/1.1 (https://github.com/go-resty/resty)

The impact of this is that our akka-http application logs warning logs when resty is calling it:

Illegal header: Illegal 'user-agent' header: Invalid input ':', expected OWS, 'EOI', tchar, product-or-comment, comment or ws (line 1, column 27): go-resty v1.1-edge - https://github.com/go-resty/resty
@jeevatkm jeevatkm self-assigned this Aug 14, 2018
@jeevatkm jeevatkm added the bug label Aug 14, 2018
@jeevatkm jeevatkm added this to the v1.9.0 Milestone milestone Aug 14, 2018
jeevatkm added a commit that referenced this issue Aug 14, 2018
@jeevatkm
#175 fix default user-agent string format
fe78a84
@jeevatkm
Copy link
Member

@korlowski I have updated the UA value format on branch user-agent-value-format. Could you try that branch and let me know. Then I will merge it to master and will be released in v1.9.0.

@jeevatkm jeevatkm mentioned this issue Aug 14, 2018
Merged
@korlowski
Copy link
Author

@jeevatkm Thanks for quick response. This new format is working fine for me. 👍

@jeevatkm
Copy link
Member

@korlowski Thanks for the confirmation.

jeevatkm added a commit that referenced this issue Aug 15, 2018
@jeevatkm
#175 fix default user-agent string format (#176)
ec17de1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
bug
Milestone
v1.9.0 Milestone
Development

Successfully merging a pull request may close this issue.

#175 fix default user-agent string format go-resty/resty
2 participants
@jeevatkm @korlowski