Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to edit request body string before the string is dumped to the debug logs #182

Closed
dapchen opened this issue Sep 6, 2018 · 4 comments · Fixed by #186
Closed

Allow user to edit request body string before the string is dumped to the debug logs #182

dapchen opened this issue Sep 6, 2018 · 4 comments · Fixed by #186
Labels
enhancement
Milestone
v1.10.0 Milestone

Comments

@dapchen
Copy link

dapchen commented Sep 6, 2018 •
edited
Loading

Sometimes a request body contains sensitive information that user would like to mask out before they share the request log with other people. Can resty make a request body string editable before the string is dumped to the debug logs?
@jeevatkm
Copy link
Member

jeevatkm commented Sep 6, 2018

@dapchen Its feasible to implement.

I think its better to make generic implementation for handling debug log before logging, so that it would satisfy #180 too.

@jeevatkm jeevatkm added this to the v1.10.0 Milestone milestone Sep 6, 2018
jeevatkm added a commit that referenced this issue Sep 19, 2018
@jeevatkm
#180 #182 debug log callback added to customize log info before logging
fdc2f93
@jeevatkm
Copy link
Member

jeevatkm commented Sep 19, 2018 •
edited
Loading

@dapchen I have added the implementation debug-log-enhancement fdc2f93, give it try and please let me know. I will merge it.

@jeevatkm jeevatkm mentioned this issue Sep 19, 2018
Merged
@dapchen
Copy link
Author

dapchen commented Sep 19, 2018

@jeevatkm I pulled in the debug-log-enhancement. I was able to mask password in my request body. Thank you for making this enhancement!

@jeevatkm
Copy link
Member

@dapchen Thank you for your feedback.

jeevatkm added a commit that referenced this issue Sep 20, 2018
@jeevatkm
#180 #182 debug log callback added to customize log info before loggi…
eae7644 
…ng (#186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
v1.10.0 Milestone
Development

Successfully merging a pull request may close this issue.

#180 #182 debug log callback added to customize log info before logging go-resty/resty
2 participants
@jeevatkm @dapchen