Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetResult fails to parse JSON when the returned Content-Type is "application/x-amz-json-1.1" #594

Closed
zackwine opened this issue Oct 25, 2022 · 2 comments · Fixed by #702
Closed

SetResult fails to parse JSON when the returned Content-Type is "application/x-amz-json-1.1" #594

zackwine opened this issue Oct 25, 2022 · 2 comments · Fixed by #702
Assignees
@jeevatkm
Labels
bug
Milestone
v2.9.0

Comments

@zackwine
Copy link

I found the SetResult API fails to parse the result JSON if the Content-Type is equal to "application/x-amz-json-1.1" (which Amazon uses for some endpoints). Would it be possible to add this as a supported Content-Type, or possibly support setting a custom JSON Content-Type for resty?

Looks like this is the regex that is failing to match: https://github.com/go-resty/resty/blob/master/client.go#L63
@segevda
Copy link
Contributor

segevda commented Oct 31, 2022

As a workaround, you can set application/json as the content-type using Request.ForceContentType method, which will force resty to unmarshall the resp body as a JSON.

tsbkw added a commit to tsbkw/resty that referenced this issue Oct 31, 2022
@tsbkw
feat: Enable to customize unmarshal rule
fd8961d 
[Issue go-resty#594](go-resty#594) can be workaround by set `application/json` as ForceContentType,
but content-type may be different depends on response, and
ForceContentType assumes that server always return same content type.

AddForceUnmarshalRule enables unmarshal depends on content-type from
server.

Previously createGenServer return xml response without root element and
it cannot be unmarshalled because encoding/xml.Unmarshal is only
unmarshal chidlren of root element.
Now add root element in response and change assertion in test case
accordingly.
tsbkw added a commit to tsbkw/resty that referenced this issue Oct 31, 2022
@tsbkw
feat: Enable to customize unmarshal rule
3bb6405 
[Issue go-resty#594](go-resty#594) can be worked around by set `application/json` as ForceContentType,
but content-type may be different depends on response, and
ForceContentType assumes that server always return same content type.

AddForceUnmarshalRule enables unmarshal depends on content-type from
server.

Previously createGenServer return xml response without root element and
it cannot be unmarshalled because encoding/xml.Unmarshal is only
unmarshal chidlren of root element.
Now add root element in response and change assertion in test case
accordingly.
@tsbkw tsbkw mentioned this issue Oct 31, 2022
Closed
@zackwine
Copy link
Author

@segevda Thanks!

jeevatkm added a commit that referenced this issue Sep 23, 2023
@jeevatkm
fix: improve regex expression for json and xml content type validation …
683c9c1 
…#594
@jeevatkm jeevatkm self-assigned this Sep 23, 2023
@jeevatkm jeevatkm added the bug label Sep 23, 2023
@jeevatkm jeevatkm added this to the v2.9.0 milestone Sep 23, 2023
@jeevatkm jeevatkm mentioned this issue Sep 23, 2023
Merged
jeevatkm added a commit that referenced this issue Sep 24, 2023
@jeevatkm
fix: improve regex expression for json and xml content type validation …
4da1873 
…#594
jeevatkm added a commit that referenced this issue Sep 24, 2023
@jeevatkm
fix: improve regex expression for json and xml content type validation …
8d8419f 
…#594 (#702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
bug
Milestone
v2.9.0
Development

Successfully merging a pull request may close this issue.

fix: improve regex expression for json and xml content type validation go-resty/resty
3 participants
@jeevatkm @zackwine @segevda