Add set scheme client option #30
Conversation
| @@ -603,6 +615,12 @@ func (c *Client) execute(req *Request) (*Response, error) { | |||
|
|
|||
| req.Time = time.Now() | |||
| c.httpClient.Transport = c.transport | |||
|
|
|||
| if req.RawRequest.URL != nil && req.RawRequest.URL.Scheme == "" { | |||
There was a problem hiding this comment.
Can you please move this complete if condition to middleware.go#L141?
|
@aanm Thank you so much for contributing to I have added couple of note, can you please have a look and take care? Also test case please for your scenario. |
|
@jeevatkm Done |
|
@aanm Thanks for your effort, I appreciate it. Travis CI check didn't pass, added a not for URL and test case. |
|
|
||
| SetScheme("http") | ||
|
|
||
| assertEqual(t, true, DefaultClient.scheme == "true") |
There was a problem hiding this comment.
this line may be -
assertEqual(t, true, DefaultClient.scheme == "http")
Signed-off-by: André Martins <aanm90@gmail.com>
|
@jeevatkm Fixed |
|
@aanm Thanks, this is helpful for community.
If you're interested, please add example too for community. I'm glad to this PR and your upcoming examples. |
|
@aanm Would you be interested in providing example for Like creating an |
Signed-off-by: André Martins aanm90@gmail.com