Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect response time when saving the response file #357

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

iwaltgen
Copy link
Contributor

When saving the response file, it was not recorded time.
as a result, incorrect calculation of response time.

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #357 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files          10       10           
  Lines        1231     1231           
=======================================
  Hits         1184     1184           
  Misses         26       26           
  Partials       21       21           
Impacted Files Coverage Δ
client.go 96.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f48b77...098a209. Read the comment docs.

@iwaltgen iwaltgen marked this pull request as ready for review July 23, 2020 06:22
@jeevatkm jeevatkm force-pushed the fix-response-time-at-save-file branch from 5d3915c to 098a209 Compare September 4, 2020 06:07
@jeevatkm jeevatkm merged commit 66bc6d2 into go-resty:master Sep 4, 2020
@iwaltgen iwaltgen deleted the fix-response-time-at-save-file branch September 4, 2020 06:24
@jeevatkm jeevatkm added this to the v2.4.0 Milestone milestone Sep 5, 2020
@jeevatkm jeevatkm added the bug label Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants