Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #403

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Enhancements #403

merged 3 commits into from
Jan 11, 2021

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Jan 11, 2021

Closes #395
Closes #387
Closes #402

Typically it is recommeneded to use standard header Authorization.
However adding this option might help some systems which
uses the custom authorization header.
@jeevatkm jeevatkm added this to the v2.4.0 Milestone milestone Jan 11, 2021
@jeevatkm jeevatkm self-assigned this Jan 11, 2021
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #403 (aa639ad) into master (de83b7e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   95.94%   95.97%   +0.02%     
==========================================
  Files          10       10              
  Lines        1012     1019       +7     
==========================================
+ Hits          971      978       +7     
  Misses         23       23              
  Partials       18       18              
Impacted Files Coverage Δ
client.go 96.77% <100.00%> (+0.03%) ⬆️
middleware.go 91.49% <100.00%> (+0.06%) ⬆️
request.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de83b7e...aa639ad. Read the comment docs.

Copy link
Contributor

@moorereason moorereason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeevatkm jeevatkm merged commit b90c855 into master Jan 11, 2021
@jeevatkm jeevatkm deleted the enhancements branch January 11, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

SetPathParam (add one parameter) How to set Content-Length header Default Authorization Key name change
2 participants