-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Export transport method to return current transport from the client #605
Conversation
Can this be merged or closed? I don't have write access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the lines changed in this commit are fixing the indentation. IMO you should remove these changes from this commit as they are unrelated. Another PR can be created to fix the indentation.
thank you for the input |
@MicBun Thanks for your PR and contribution. I'm sorry for the delayed attention on the PR. May I know the context of the PR! I couldn't understand, why its needed. |
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 11 11
Lines 1559 1559
=======================================
Hits 1494 1494
Misses 40 40
Partials 25 25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MicBun Thanks for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MicBun I just noticed, this PR contains unnecessary commits. Can you please update your PR with only your changes or create a new?
After that we can merge this one.
sure, thank you for the feedback |
fyi: the transport is already accessible via http.Client
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MicBun
Fixes #601