Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of deprecated io/ioutil #625

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

segevda
Copy link
Contributor

@segevda segevda commented Mar 9, 2023

io/ioutil has been deprecated since go1.16, and its functionality has been moved to io and os packages.

io/ioutil has been deprecated since go1.16, and its functionality
has been moved to io and os packages.
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #625 (6400907) into master (1578007) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master     #625   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          10       10           
  Lines        1383     1383           
=======================================
  Hits         1326     1326           
  Misses         35       35           
  Partials       22       22           
Impacted Files Coverage Δ
client.go 97.83% <50.00%> (ø)
middleware.go 90.64% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@segevda
Copy link
Contributor Author

segevda commented Mar 9, 2023

I don't see how a commit that adds no new statements (quite the opposite - it removes several statements) can lower the coverage. @jeevatkm please take a look 🙏

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @segevda for the PR, appreciated!

@jeevatkm jeevatkm merged commit 9a7415a into go-resty:master Mar 11, 2023
@jeevatkm jeevatkm added this to the v2.8.0 Milestone milestone Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants