-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed JSON request logging data race. #775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v2 #775 +/- ##
==========================================
- Coverage 96.52% 96.46% -0.06%
==========================================
Files 12 12
Lines 1639 1643 +4
==========================================
+ Hits 1582 1585 +3
- Misses 36 37 +1
Partials 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) | `v2.11.0` -> `v2.12.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-resty%2fresty%2fv2/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-resty%2fresty%2fv2/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-resty%2fresty%2fv2/v2.11.0/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-resty%2fresty%2fv2/v2.11.0/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-resty/resty (github.com/go-resty/resty/v2)</summary> ### [`v2.12.0`](https://github.com/go-resty/resty/releases/tag/v2.12.0) [Compare Source](https://github.com/go-resty/resty/compare/v2.11.0...v2.12.0) ### Release Notes #### Enhancements - Add Client.Clone function by [@​fabiante](https://github.com/fabiante) in [go-resty/resty#774 #### Bug Fixes - Fixed JSON request logging data race. by [@​buglloc](https://github.com/buglloc) in [go-resty/resty#775 - fix: trailing NULL bytes in buffer while detecting a content type by [@​jeevatkm](https://github.com/jeevatkm) in [go-resty/resty#779 - fix: encode path params with BaseURL and the first param at index zero ([#​781](https://github.com/go-resty/resty/issues/781)) by [@​sakateka](https://github.com/sakateka) in [go-resty/resty#782 #### Documentation - fix: doc typo by [@​victoraugustolls](https://github.com/victoraugustolls) in [go-resty/resty#769 - docs: replace `SetHostURL` to `SetBaseURL` by [@​purofle](https://github.com/purofle) in [go-resty/resty#772 - for v2.12.0 release by [@​jeevatkm](https://github.com/jeevatkm) in [go-resty/resty#783 #### New Contributors - [@​victoraugustolls](https://github.com/victoraugustolls) made their first contribution in [go-resty/resty#769 - [@​purofle](https://github.com/purofle) made their first contribution in [go-resty/resty#772 - [@​buglloc](https://github.com/buglloc) made their first contribution in [go-resty/resty#775 - [@​fabiante](https://github.com/fabiante) made their first contribution in [go-resty/resty#774 - [@​sakateka](https://github.com/sakateka) made their first contribution in [go-resty/resty#782 **Full Changelog**: go-resty/resty@v2.11.0...v2.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Michsior14/transmission-gluetun-port-update). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
noescapeJSONMarshalIndent
must either copy the buffer data or don't put it into the sync.Pool (similar tonoescapeJSONMarshal
). Otherwise, we could have a data race: