Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial PostgreSQL support #170

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Initial PostgreSQL support #170

merged 1 commit into from
Sep 25, 2019

Conversation

bvp
Copy link
Contributor

@bvp bvp commented Sep 24, 2019

No description provided.

@RadhiFadlillah RadhiFadlillah merged commit c2eee1d into go-shiori:master Sep 25, 2019
@RadhiFadlillah
Copy link
Collaborator

Hey, thanks !

@bvp
Copy link
Contributor Author

bvp commented Sep 25, 2019

Thank you ;)
Need to update wiki

@nfam
Copy link
Contributor

nfam commented Sep 30, 2019

Hi @bvp, thank you for PostgreSQL support. I love this DB.
However I could not view an individual bookmark (eg. Bookmark not found). Reviewing func (db *PGDatabase) GetBookmark() in the file shiori/internal/database/pg.go, I found SQL syntax error.

SELECT
	id, url, title, excerpt, author, public, 
	content, html, modified, content <> "" has_content
FROM bookmark WHERE id = $1

I think it should be single quote '' instead of double route "", so it should be

SELECT
	id, url, title, excerpt, author, public, 
	content, html, modified, content <> '' has_content
FROM bookmark WHERE id = $1

@RadhiFadlillah
Copy link
Collaborator

@nfam nice catch, thanks. It has been fixed in 9ba9d1e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants