Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies and Replace mattn/go-sqlite with modernc.org/sqlite #345

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Conversation

n8225
Copy link
Contributor

@n8225 n8225 commented Feb 7, 2022

This PR replaces mattn/go-sqlite with modernc.org/sqlite, updates all dependencies, and brings go version to 1.17
Static binaries can now be built without cgo.
In my limited testing everything appears to be working. It probable needs some more thorough testing.

#254 #253

@fmartingr
Copy link
Member

Hey @n8225, sorry I didn't notice this earlier! I have properly adjusted my watch settings so I get notified of all activity.

That said, thanks a lot for this! Way to go forward. if you could just edit the CI to remove the check for older go versions and leave 1.17 only (hoping that works) would be awesome. We can review the speficics of the CI in future PRs.

@fmartingr fmartingr self-requested a review February 10, 2022 15:33
@n8225
Copy link
Contributor Author

n8225 commented Feb 10, 2022

I will hopefully be done redoing the whole CI/CD process in the next few days. If you want I can remove the older go version checks in this PR.

@fmartingr
Copy link
Member

If you want I can remove the older go version checks in this PR.

Please do that, I just can't stand that red cross before merging a PR, also, we don't need them anyway, only 1.17 for now.

I will hopefully be done redoing the whole CI/CD process in the next few days.

That's just awesome :)

@fmartingr
Copy link
Member

Also, can you verify that the shiori data dir does not change with the library upgrades? I did this on a commit in my fork and the data dir changed from ~/.local/share/shiori/shiori.db to ~/.local/share/shiori/shiori/shiori.db. Thanks!

@fmartingr fmartingr force-pushed the master branch 4 times, most recently from d1ffd75 to d70a8f2 Compare February 10, 2022 21:57
@n8225
Copy link
Contributor Author

n8225 commented Feb 10, 2022

Also, can you verify that the shiori data dir does not change with the library upgrades? I did this on a commit in my fork and the data dir changed from ~/.local/share/shiori/shiori.db to ~/.local/share/shiori/shiori/shiori.db. Thanks!

I verified the data dir is still ~/.local/share/shiori/shiori.db

@fmartingr
Copy link
Member

Awesome! Let's merge this right away. Thank you @n8225 !!

@fmartingr fmartingr merged commit f1c98a8 into go-shiori:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants