Separate Linux and MacOS CI release build jobs #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8d0445ef3-PR-738
💛 - Coveralls |
ARolek
approved these changes
Feb 13, 2021
Compiling MacOS release builds on Linux, as the GitHub Actions CI job does now, means cgo isn't enabled, which means the go-sqlite3 package isn't compiled, which means no GeoPackage support in the MacOS builds. This commit separates the jobs so that Linux builds are compiled on the ubuntu-latest runner while MacOS builds are compiled on the macos-latest runner. This means no cross-compilation is required and cgo can run happily. For further details, see the discussion at #736.
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling MacOS release builds on Linux — as the GitHub Actions CI job does now — means cgo isn't enabled, which means the go-sqlite3 package isn't compiled, which means no GeoPackage support in the MacOS builds.
This pull request separates the jobs so that Linux builds are compiled on the
ubuntu-latestrunner while MacOS builds are compiled on themacos-latestrunner. This means no cross-compilation is required and cgo can run happily.Resolves #736