Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tegola_lambda CI to use Amazon Linux for building #790

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

ARolek
Copy link
Member

@ARolek ARolek commented Jul 19, 2021

AWS Lambda uses Amazon Linux for Lambda executions. The previous
build pipeline was using Ubuntu 18.04 to build tegola_lambda
which had GLIB location parity with Amazon Linux. After upgrading
to Ubuntu 20.04 the GLIB references between Ubuntu and Amazon Linux
are no longer in parity so tegola_lambda fails to find GLIB during
Lambda execution.

This commit accomplished the following:

  • build tegola_lambda using Amazon Linux rather than Ubuntu
  • move from using ubuntu-latest to ubuntu-20.04 in GH actions.

closes #789

@coveralls
Copy link

coveralls commented Jul 19, 2021

Pull Request Test Coverage Report for Build 7564919ab-PR-790

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.052%

Totals Coverage Status
Change from base Build 126d51113: 0.0%
Covered Lines: 5440
Relevant Lines: 12075

💛 - Coveralls

@ARolek ARolek force-pushed the issue-789-tegola_lambda-glib-bug branch from cb86ba1 to 9564720 Compare July 19, 2021 21:25
AWS Lambda uses Amazon Linux for Lambda executions. The previous
build pipeline was using Ubuntu 18.04 to build tegola_lambda
which had GLIB location parity with Amazon Linux. After upgrading
to Ubuntu 20.04 the GLIB references between Ubuntu and Amazon Linux
are no longer in parity so tegola_lambda fails to find GLIB during
Lambda execution.

This commit accomplished the following:

* build tegola_lambda using Amazon Linux rather than Ubuntu
* move from using ubuntu-latest to ubuntu-20.04 in GH actions.

closes #789
@ARolek ARolek force-pushed the issue-789-tegola_lambda-glib-bug branch from 9564720 to 4ab36cc Compare July 19, 2021 21:29
@ARolek ARolek requested a review from gdey July 19, 2021 22:39
@ARolek ARolek marked this pull request as ready for review July 19, 2021 22:39
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; only one minor comment about using the latest tag for amazonlinux, instead of specifying a version. This way we aren't caught by surprise again.

@ARolek ARolek merged commit 4ab36cc into v0.14.x Jul 21, 2021
@ARolek ARolek deleted the issue-789-tegola_lambda-glib-bug branch July 21, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aws lambda Execution failed - /lib64/libc.so.6: version `GLIBC_2.28' not found
3 participants