Allow link in attribution #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ARolek
requested changes
Aug 20, 2021
cmd/internal/register/maps.go
Outdated
| newMap.Attribution = html.EscapeString(string(cfg.Attribution)) | ||
|
|
||
| attribution := html.EscapeString(string(cfg.Attribution)) | ||
| re := regexp.MustCompile(`<(a\s(.+?)|/a)>`) |
There was a problem hiding this comment.
Please move the regexp.MustCompile outside the function call.
cmd/internal/register/maps.go
Outdated
Comment on lines
17
to
22
| attribution := html.EscapeString(string(cfg.Attribution)) | ||
| re := regexp.MustCompile(`<(a\s(.+?)|/a)>`) | ||
| tags := re.FindAllString(attribution, -1) | ||
| for _, tag := range tags { | ||
| attribution = strings.Replace(attribution, tag, html.UnescapeString(tag), 1) | ||
| } |
There was a problem hiding this comment.
You could move this to a separate function and maybe call it sanitizeAttribution. That would allow you to add your test cases to the codebase which would be ideal.
|
Please review the new commits |
|
@underspica this looks excellent! Thanks for making the adjustments. The last request is to squash everything into a single commit then I will get this merged in. Thank you! |
Allow link in attribution Test SanitizeAttribution
|
Done, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #798
Allow link in attribution by unescape anchor tag.