Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove logAndError #839

Merged
merged 1 commit into from
Mar 14, 2022
Merged

chore: remove logAndError #839

merged 1 commit into from
Mar 14, 2022

Conversation

iwpnd
Copy link
Member

@iwpnd iwpnd commented Mar 10, 2022

As discussed I'm removing the logAndError helper and let control logging for those three occasions in the error block. If you disagree with me on the Debug instead of the Info log, please feel free to just change it around. :)

@iwpnd iwpnd requested review from gdey and ARolek as code owners March 10, 2022 12:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 59148f0ae-PR-839

  • 6 of 10 (60.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 45.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/handle_map_layer_zxy.go 6 10 60.0%
Files with Coverage Reduction New Missed Lines %
server/handle_map_layer_zxy.go 1 77.5%
Totals Coverage Status
Change from base Build 2fad34008: -0.02%
Covered Lines: 5485
Relevant Lines: 12158

💛 - Coveralls

Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ARolek
Copy link
Member

ARolek commented Mar 11, 2022

@gdey do you think Debug or Info should be used in these log statements. That's the only real question in this PR.

Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Debug seems good, another good one might be TRACE. But I think debug is good.

@gdey
Copy link
Member

gdey commented Mar 14, 2022

@gdey do you think Debug or Info should be used in these log statements. That's the only real question in this PR.

I think debug is fine. I don't think these are really Info-level messages, as it might be expected to have these happen, but if you are trying to figure out why it's not happening then opening it up to debug would be good. The only other level I can think of that might make sense is TRACE, but that's supposed to be even more verbose than debug. So, debug is good.

@ARolek ARolek merged commit 21da05b into go-spatial:v0.15.x Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants