Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed it so the CI build UI #856

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Fixed it so the CI build UI #856

merged 1 commit into from
Jun 2, 2022

Conversation

gdey
Copy link
Member

@gdey gdey commented May 26, 2022

The UI stopped getting build by the CI. Updated the
workflow files to build the UI and upload it as an
artifact that people can use.

  • Improved version command to contain additional version
    information about the binary.
  • Imporved the workflow to reduce amount of duplicated work
  • include branch name as part of version information.

fixes #855

@gdey gdey requested a review from ARolek as a code owner May 26, 2022 01:05
@coveralls
Copy link

coveralls commented May 26, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build b9de118f4-PR-856

  • 2 of 7 (28.57%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 45.489%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/server.go 2 3 66.67%
cmd/tegola/cmd/version.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/tegola/cmd/version.go 1 0%
Totals Coverage Status
Change from base Build 2e53a6534: -0.01%
Covered Lines: 5591
Relevant Lines: 12291
💛 - Coveralls

ARolek
ARolek approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor comments inline. Thanks for getting this fixed!

.github/workflows/on_release_publish.yml Outdated Show resolved Hide resolved
.github/workflows/on_release_publish.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@gdey gdey force-pushed the fix_ui_build branch 9 times, most recently from 4b59b6a to 59ce439 Compare May 27, 2022 06:49
@gdey gdey requested a review from ARolek May 27, 2022 06:49
ARolek
ARolek approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for cleaning all this up.

@gdey
Fixed it so the CI build UI
6387c67 
The UI stopped getting build by the CI. Updated the
workflow files to build the UI and upload it as an
artifact that people can use.

* Improved version command to contain additional version
information about the binary.
* Imported the workflow to reduce amount of duplicated work
* include branch name as part of version information.
* moved redundant task to local actions to improve reuse of workflow code

fixes #855
@gdey gdey merged commit 6387c67 into master Jun 2, 2022
@ARolek ARolek deleted the fix_ui_build branch July 27, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARolek ARolek ARolek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getting started
3 participants
@gdey @coveralls @ARolek