Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config max zoom 0 #874

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix: config max zoom 0 #874

merged 1 commit into from
Aug 30, 2022

Conversation

iwpnd
Copy link
Member

@iwpnd iwpnd commented Jul 24, 2022

as per #870, setting max_zoom to 0 currently causes the layer to bleed through
over the entire zoom range. Either we fix filtering as per #871
or make sure max_zoom is never 0 as I do in this PR.

@coveralls
Copy link

coveralls commented Jul 24, 2022

Pull Request Test Coverage Report for Build 41ebf1ba3-PR-874

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 45.309%

Totals Coverage Status
Change from base Build a78880d9a: 0.04%
Covered Lines: 5607
Relevant Lines: 12375

💛 - Coveralls

Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

as per go-spatial#870, setting max_zoom to 0 currently causes the layer to bleed through
over the entire zoom range. Either we fix filtering as per go-spatial#871
or make sure max_zoom is never 0 as I do in this PR.
@gdey gdey merged commit 73156d8 into go-spatial:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants