Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable param example to README #896

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add configurable param example to README #896

merged 1 commit into from
Dec 8, 2022

Conversation

bemyak
Copy link
Contributor

@bemyak bemyak commented Dec 2, 2022

No description provided.

@bemyak bemyak mentioned this pull request Dec 2, 2022
Closed
@coveralls
Copy link

coveralls commented Dec 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build b815d1898-PR-896

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.322%
Totals Coverage Status
Change from base Build 759c6aa4a: 0.0%
Covered Lines: 5745
Relevant Lines: 12676
💛 - Coveralls

@bemyak bemyak force-pushed the configurable-parameters-readme branch from a2a4949 to 01e9eb9 Compare December 7, 2022 09:07
ARolek
ARolek approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

gdey
gdey approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@ARolek ARolek merged commit 01e9eb9 into go-spatial:master Dec 8, 2022
@trideset3
Copy link
Contributor

Maybe also add !PARAM! to README in providers.layers so it is more clear?

sql = "SELECT ST_AsMVTGeom(geom,!BBOX!) AS geom, gid FROM gis.landuse WHERE geom && !BBOX! !PARAM!"

@ARolek
Copy link
Member

ARolek commented Apr 15, 2024

@trideset3 yeah that would help. Do you want to send in a quick PR with the documentation update?

@trideset3
Copy link
Contributor

@ARolek sure, I'll open up a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdey gdey gdey approved these changes

@ARolek ARolek ARolek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bemyak @coveralls @trideset3 @ARolek @gdey