Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapLibre - Vue3 - Vite Migration v2 #926

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

mapl
Copy link

@mapl mapl commented May 2, 2023

Hi everyone, this is my 2nd attempt to migrate the internal UI Viewer project.

All the UI (dev) libraries have been updated to the most recent versions.

Mapbox -> MapLibre
Vue2 -> Vue3
Vue Cli -> Vite

@mapl mapl requested review from ARolek and gdey as code owners May 2, 2023 23:14
@coveralls
Copy link

coveralls commented May 2, 2023

Pull Request Test Coverage Report for Build dcb237d0f-PR-926

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.906%

Totals Coverage Status
Change from base Build 4cf25e057: 0.0%
Covered Lines: 6556
Relevant Lines: 13977

💛 - Coveralls

Copy link
Member

@iwpnd iwpnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i checked out the PR, build and tested the viewer and did not find anything out of the ordinary. seems to be working just right.

some nitpicks. i would like to get rid of traces of mapbox in the naming and clean up comments that are still there left an right. but thats about it.

looks good 👍

ui/src/components/LeftNav/LeftNav.vue Outdated Show resolved Hide resolved
ui/src/components/ViewerMapbox.vue Outdated Show resolved Hide resolved
@@ -6,7 +6,7 @@
import { store, mutations } from "@/globals/store";
import { mapSetters } from "@/globals/map";
import ToggleTileBoundariesControl from "./MapboxControls";
import mapboxgl from "mapbox-gl";
import mapboxgl from "maplibre-gl";

export default {
name: "ViewerMapbox",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

ui/src/globals/store.js Outdated Show resolved Hide resolved
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in here! Thanks for tackling this. I don't have any additional comments beyond what @iwpnd pointed out.

Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in here! Thanks for tackling this. I don't have any additional comments beyond what @iwpnd pointed out.

@ARolek
Copy link
Member

ARolek commented Jun 8, 2023

@iwpnd it looks like all your comments have been addressed. Would you mark the PR approved if you don't have any additional change requests?

@iwpnd
Copy link
Member

iwpnd commented Jun 9, 2023

my bad, wasn't aware that I was appointed a reviewer and was blocking this

@ARolek
Copy link
Member

ARolek commented Jun 9, 2023

@iwpnd no worries! I just want to get your approval as you have worked on this part of the codebase.

@ARolek ARolek merged commit bd4f62e into go-spatial:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants