Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker image viewer UI #947

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix docker image viewer UI #947

merged 1 commit into from
Aug 30, 2023

Conversation

manastyretskyi
Copy link
Contributor

Fixes #945

Adding context: . fixes issue with missing files. I've pushed image to my own repository so that you would be able test it as well.

ARolek
ARolek approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for testing too.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 31cc7c6c8-PR-947

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.906%
Totals Coverage Status
Change from base Build 096b5d903: 0.0%
Covered Lines: 6556
Relevant Lines: 13977
💛 - Coveralls

@ARolek ARolek merged commit f5aa603 into go-spatial:master Aug 30, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARolek ARolek ARolek approved these changes

@gdey gdey Awaiting requested review from gdey gdey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.18.0 Docker image has no viewer UI
3 participants
@manastyretskyi @coveralls @ARolek