[FIX] Issue 904 - Vue app doesn't take into account uri_prefix #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nactik
changed the title
Nactik
changed the title
Pull Request Test Coverage Report for Build c9799a7f2-PR-967Details
💛 - Coveralls |
|
@Nactik nice! LMK when this is out of draft and I will give it a review. |
|
@ARolek |
iwpnd
reviewed
Feb 12, 2024
iwpnd
approved these changes
Feb 12, 2024
ARolek
approved these changes
Feb 17, 2024
| @@ -477,6 +479,163 @@ func TestParse(t *testing.T) { | |||
| expected: config.Config{}, | |||
| expectedErr: env.ErrEnvVar("I_AM_MISSING"), | |||
| }, | |||
| "4 test empty proxy_protocol": { | |||
| config: ` | |||
There was a problem hiding this comment.
I wonder if we should move these inline configs to external files. it sure would make this easier to look it ;-)
Nactik
force-pushed
the
issue-904-fix_uri_prefix_for_ui
branch
from
c24f900
to
9d0020a
Compare
Remove prefix from static file to serve behind proxy
Config vite to serve static file as embedded (Relative path)
Update lock file
Add Scheme tests
Add test for BuildCapabilitiesUrl
Add comment on ProxyProtol settings
Convert interface{} to any
Reset ProxyProtocol when not set
Nactik
force-pushed
the
issue-904-fix_uri_prefix_for_ui
branch
from
7217051
to
387be73
Compare
|
Just merged this into master. Great for contribution! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #904 - uri_prefix not taken into account for the UI
Hey there, here's a quick PR to fix the way tegola UI is served when sitting behind a reverse proxy. I still need to implement and fix test but the idea is here (I will implement them asap)
Changes:
proxy_protocol(I can change it if you think of a better name) in the config file (config.toml) to set a custom protocol that will be used to generate the URLs included in the capabilities endpoint responses. (Useful when working under a reverse proxy and when theX-Forwarded-Protois not a solution - Fix Specify client protocol in config #134 )uri_prefixfrom the request (server/viewer_embed.go)vitesettings to include static file using a relative path