feat: allow dbconfig options #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 746b513e9-PR-968Details
💛 - Coveralls |
ARolek
reviewed
Feb 24, 2024
Comment on lines
+18
to
+28
| host := ttools.GetEnvDefault("PGHOST", "localhost") | ||
| port, err := strconv.Atoi(ttools.GetEnvDefault("PGPORT", "5432")) | ||
| // if port is anything but int, fallback to default | ||
| if err != nil { | ||
| port = 5432 | ||
| } | ||
| database := ttools.GetEnvDefault("PGDATABASE", "tegola") | ||
| user := ttools.GetEnvDefault("PGUSER", "postgres") | ||
| password := ttools.GetEnvDefault("PGPASSWORD", "postgres") | ||
|
|
||
| cs := fmt.Sprintf("postgres://%v:%v@%v:%v/%v", user, password, host, port, database) |
There was a problem hiding this comment.
Note to self, I need to update our CI's env vars to have connection strings so you don't need to do this juggle.
iwpnd
force-pushed
the
feat/dbconfig_options
branch
from
98bc702
to
a2a3049
Compare
Done. My pleasure 🙏 |
ARolek
approved these changes
Feb 27, 2024
application_name and default_transaction_read_only to be configurable Closes: go-spatial#966 fix: compare default_transaction_read_only with uppercase chore: use const for runtime param keys, update readme
ARolek
force-pushed
the
feat/dbconfig_options
branch
from
a2a3049
to
ef1023c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
application_nameanddefault_transaction_read_onlyto be configurableCloses: #966