Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecate non uri connection #986

Merged
merged 1 commit into from
Mar 28, 2024
Merged

refactor: deprecate non uri connection #986

merged 1 commit into from
Mar 28, 2024

Conversation

iwpnd
Copy link
Member

@iwpnd iwpnd commented Mar 20, 2024

closes #979

@iwpnd iwpnd requested review from gdey and ARolek as code owners March 20, 2024 16:50
@coveralls
Copy link

coveralls commented Mar 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 532a62fc0-PR-986

Details

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 46.722%
Changes Missing Coverage Covered Lines Changed/Added Lines %
provider/postgis/postgis.go 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
provider/postgis/postgis.go 3 59.77%
Totals Coverage Status
Change from base Build df626042b: -0.2%
Covered Lines: 6542
Relevant Lines: 14002
💛 - Coveralls

ARolek
ARolek requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good in here! I only have some minor comments inline, mainly around adding some documentation referencing the pgxpool.ParseConfig function which has additional connection string params that we have deprecated config support for, but are still supported in the connection string.

provider/postgis/postgis.go Outdated Show resolved Hide resolved
mvtprovider/postgis/README.md Show resolved Hide resolved
gdey
gdey approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when you have a chance can you rebase the commits into a single narrative.

ARolek
ARolek approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean! Thanks for tackling that. Please squash the commits into a single one and then we can land this PR and get v0.20.0 of tegola released!

@iwpnd
refactor: deprecate non-uri connection
3768bcc 
docs: update

ci: update

fix: remove default options

chore: resolve issues

docs: update mvt provider readme too
@iwpnd iwpnd force-pushed the refactor/deprecate-non-uri-connection branch from ac1361e to 3768bcc Compare March 24, 2024 12:18
@iwpnd
Copy link
Member Author

iwpnd commented Mar 26, 2024

lets go @ARolek

@ARolek ARolek merged commit 226cc58 into go-spatial:master Mar 28, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARolek ARolek ARolek approved these changes

@gdey gdey gdey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provider/postgis: Clean out deprecated connection params
4 participants
@iwpnd @coveralls @gdey @ARolek