Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --max-runs flag to control number of times a task should run before termination + minor bug fixes #1332
Adding --max-runs flag to control number of times a task should run before termination + minor bug fixes #1332
Changes from 4 commits
3691845
b5db153
6bddb6a
52589b7
6d48d50
58f7759
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not requesting any changes to this now. Just opening this up for thoughts and opinions as naming is always hard. Some other possibilities:
--limit
- Nice and short, but might be too generic (could clash with something likeinclude-limit
if we wanted it)--call-limit
--max-task-calls
- Very explicit, but longer. I don't think length is a huge issue with these flags as they're most likely to be used in CI or scripts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I'd like to shorten the description. I couldn't find more concise (yet complete) description.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.